Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump odo version to 1.0.0-beta7 #2276

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Bump odo version to 1.0.0-beta7 #2276

merged 2 commits into from
Oct 15, 2019

Conversation

amitkrout
Copy link
Contributor

@amitkrout amitkrout commented Oct 11, 2019 •
edited
Loading

Enhancements:
Issue #1672 - Help message is overwhelming for first time users
Issue #2232 - odo describe should also show secrets / linked variables from other components and services
#2283 - Updating spec to use make prepare-release to create binaries
#2240 - Adds unit test for project list
#2268 - Making debug command test target in sync
#2231 - Updates odo describe output
#2213 - Updates environment variable output
#2187 - Move dev documentation to /dev
#2188 - Updates the README formatting and adds crc

Bug Fixes:
Issue #2138 - odo watch should fail with error message for git based components
Issue #2156 - show warning for supported and unsupported images when doing odo create/push
Issue #2192 - "odo push" panics for component created in interactive mode
Issue #2235 - Format json output by default or add an option for that
Issue #2224 - odo link Fails to Link Java Component to Node.js Component
Issue #2260 - wrong help in odo url
Issue #2243 - Removing --app, --project, --component from subcommands that depends on component dir
Issue #2148 - Should we mention "Supported" / "Unsupported" in components list output for community images?
Issue #2203 - "odo storage create" with "--app" and "--project" flags is broken
Issue #2117 - Project create doesn't wait properly
Issue #1969- --binary flag doesn't work without --context flag while creating component
Issue #2032 - "odo component list --path" shows incorrect "STATE" when components belong to different projects
Issue #2186 - odo list --path fails when not in component directory
Issue #2195 - odo storage commands should mention the need of odo push for changes to take effect
Issue #2163 - odo create interactive generates incorrect config
#2278 - Change Odo Reference to odo for cli-docs
#2252 - Update test reports path in gitignore file
#2241 - Correct odo debug Typo
#2234 - Add crc stop to Deploy Application Section of README
#2230 - ComponentTypeList should be List in machine output
#2229 - ServiceTypeList should be List in machine output
#2228 - Machine output for odo app list should be Kind: List
#2226 - Edits to Deploying an application using odo Section of README
#2199 - fix sha256 generation for release
#2214 - Removing Odo References from CLI
#2206 - Fix random ginkgo input in test script
#2205 - Fix typo in odo debug help output
#2190 - log stdout and stderr of tar command

Testing:
Issue #2262 - Link tests are never executed!!
Issue #2184 - Fixing no such file or directory issue

Documentation
Issue #2254 - Grammar incorrect for "odo create" project creation.
The downstream documentation has been created and integrated within the OpenShift Container Platform, OpenShift Dedicated and OpenShift Online distribution.

NOTE: Remote debugging feature will continue as an experimental in v1.0.0-beta7 release.

@amitkrout amitkrout changed the title Bump odo version to 1.0.0-beta7 [WIP]Bump odo version to 1.0.0-beta7 Oct 11, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Oct 11, 2019
@amitkrout amitkrout force-pushed the release1.0.0-beta7 branch 2 times, most recently from a033e6d to 6f65602 Compare October 11, 2019 13:33
@amitkrout amitkrout changed the title [WIP]Bump odo version to 1.0.0-beta7 Bump odo version to 1.0.0-beta7 Oct 11, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Oct 11, 2019
@amitkrout
Copy link
Contributor Author

Tested on platform other than CI

Windows10 + OpenShift 4.2 : All test script went fine
NOTE: Only two test spec of link-unlink command test has been tested because rest spec depend on service catalog.

macOS + OpenShift 4.2 : All test went fine except e2e-java test. Issue #2282 is created.
NOTE: It is not a release blocker

@amitkrout
Copy link
Contributor Author

ping @kadel @girishramnani

@kadel
Copy link
Member

kadel commented Oct 14, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 14, 2019
@amitkrout
Copy link
Contributor Author 

✗  Waiting for build to finish [30s]
[odo]  ✗  Failed to create component with name wo-wait-javaee-git-test. Please use `odo config view` to view settings used to create component. Error: unable to wait for build wo-wait-javaee-git-test-app-1 to run: timed out waiting for the condition

/test v4.1-e2e-scenarios

@amitkrout
Copy link
Contributor Author 

[odo]  ✗  Waiting for build to finish [30s]
[odo]  ✗  Failed to create component with name uberjar-git-test. Please use `odo config view` to view settings used to create component. Error: unable to wait for build uberjar-git-test-app-1 to run: timed out waiting for the condition

/test v4.1-e2e-scenarios

mohammedzee1000
mohammedzee1000 approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@mohammedzee1000 mohammedzee1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 15, 2019
@amitkrout
Copy link
Contributor Author

/test v4.1-integration

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 15, 2019
@mohammedzee1000
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 15, 2019
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@prietyc123
Copy link
Contributor

/lgtm

@amitkrout
Copy link
Contributor Author

/test v4.2-e2e-scenarios
/test v4.1-benchmark

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5e61b16 into redhat-developer:master Oct 15, 2019
@rm3l rm3l added the estimated-size/L (20-40) Rough sizing for Epics. About 2 sprints of work for a person. label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammedzee1000 mohammedzee1000 mohammedzee1000 approved these changes

@girishramnani girishramnani Awaiting requested review from girishramnani

@kadel kadel Awaiting requested review from kadel

Assignees

@mohammedzee1000 mohammedzee1000

@prietyc123 prietyc123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/L (20-40) Rough sizing for Epics. About 2 sprints of work for a person. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@amitkrout @kadel @openshift-ci-robot @openshift-bot @mohammedzee1000 @prietyc123 @rm3l @openshift-merge-robot